Skip to content

adjusting how children are added to clipboard #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2025
Merged

adjusting how children are added to clipboard #605

merged 4 commits into from
Nov 6, 2025

Conversation

@omarArm
Copy link
Collaborator

@omarArm omarArm commented Nov 4, 2025

Fixes

Changes

  • When copying children expressions, the expression added to the clipboard used to be only the child's name. Now it got changed to include parent's name as well

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Nov 4, 2025 •
edited
Loading

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will not change total coverage.

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@jreineckearm jreineckearm self-requested a review November 6, 2025 12:50
jreineckearm
jreineckearm approved these changes Nov 6, 2025
View reviewed changes
Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the copy to clipboard, thanks!
Found a few more problems to look at as I communicated to you offline. Captured here #609 and to be looked at in the coming days.

@jreineckearm jreineckearm merged commit 73063bf into main Nov 6, 2025
15 checks passed
@jreineckearm jreineckearm deleted the liveWatchCopyExpression branch November 6, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreineckearm jreineckearm jreineckearm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omarArm @jreineckearm